Skip to content

Avoid empty asset updates#168

Merged
tobiasehlert merged 3 commits into
mainfrom
dev/kamilon/avoidemptyupdate
Jun 17, 2026
Merged

Avoid empty asset updates#168
tobiasehlert merged 3 commits into
mainfrom
dev/kamilon/avoidemptyupdate

Conversation

@kamilon

@kamilon kamilon commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

This PR makes 4 changes to the flow:

  1. When the data received from Tibia.com is not in the expected shape, exit with code 1 to fail the workflow.
  2. Retry getting data up to 5 (from 2) times with exponential backoff (1s, 2s, 4s, 8s, 16s).
  3. If house data is not successful after all attempts, exit with code 1 to fail the workflow.
  4. If worlds or houses is empty when getting data from Tibia.com, the site must be in maintenance mode, exit with code 1 to fail the workflow.

Errors are logged in all 4 cases.

Fix a typo in logging.

@kamilon kamilon requested a review from tobiasehlert April 23, 2026 05:38

@tobiasehlert tobiasehlert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobiasehlert tobiasehlert merged commit d92c52f into main Jun 17, 2026
3 checks passed
@tobiasehlert tobiasehlert deleted the dev/kamilon/avoidemptyupdate branch June 17, 2026 19:26
@tobiasehlert tobiasehlert added enhancement New feature or request go Pull requests that update Go code labels Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request go Pull requests that update Go code

Development

Successfully merging this pull request may close these issues.

2 participants